Skip to content

Rolling mean notebook #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
znicholls wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rolling mean notebook #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98f2c5
Add note about notebook to write
znicholls May 3, 2021
12dc6f7
Start on notebook
znicholls May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4,415 changes: 4,415 additions & 0 deletions notebooks/rolling-mean.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions tests/unit/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import datetime as dt
import re
from unittest.mock import patch

Expand Down Expand Up @@ -989,3 +990,7 @@ def test_linear_regression_scmrun():
assert_scmdf_almost_equal(
res, exp, allow_unordered=True, check_ts_names=False, rtol=1e-3
)


# TODO: notebook illustrating rolling mean options
# Rationale: rolling means are really tricky (do you take e.g. an annual mean first, do you worry about happens at the window edge?) and they're pretty easy to convert back into ScmRun objects so a notebooks is probably more helpful than exact functionality for now