[BUG] get_task removes the dir even if was already existing
#1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
requested changes
Dec 31, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
This fixes one of the issues present, so you need to remove the xfails now.
fkiraly
approved these changes
Dec 31, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Fixed the one discrepancy
fkiraly
pushed a commit
that referenced
this pull request
Dec 31, 2025
….8, 3.9 after EOL, marking further failing tests as `xfail` (#1579) The CI runs only on python versions 3.8 and 3.9 both of which have already reached end of life. This PR updates the python versions, deprecating any logic that runs tests on python versions 3.8 and 3.9, or `scikit-learn` versions of that age. #### Metadata Reference Issue: #1544 Depends on #1584 fofr a fix, which should be merged first. #### Details * The test matrix is updated to python versions, 3.10-3.13. * Further failing tests are skipped using `mark.xfail` with `reason="failures_issue_1544" ` for all the remaining failed tests (after #1572) in issue: #1544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata
xfail#1579Details
get_taskchecks if thetid_cache_dirwas already existing before removing it onExceptionOpenMLServerExceptioncausesget_taskto remove the entire directory even if the directory was already existing and is used by other testsobserve
exists assertionerrors for files undertests/files/org/openml/test/task/1/after runningpytestor look at failures in [MNT] extend CI to newer python versions, deprecate python versions 3.8, 3.9 after EOL, marking further failing tests as
xfail#1579