-
-
Notifications
You must be signed in to change notification settings - Fork 210
[ENH] Simplified Publish API with Automatic Type Recognition #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this is a draft still, some early comments.
- works for flows only, I would recommend to try for at least two different object types to see the dispatching challenge there.
- do the extension checking inside
publishand not in the usage example
|
Thanks @fkiraly !! |
|
The PR description is not entirely correct. This is how the interface looks currently: from openml_sklearn.extension import SklearnExtension
from sklearn.neighbors import KNeighborsClassifier
clf = KNeighborsClassifier(n_neighbors=3)
extension = SklearnExtension()# User instantiates the extension object
knn_flow = extension.model_to_flow(clf) # User manually converts the model (estimator instance) to an OpenMLFlow object
knn_flow.publish()But I like the idea of a unified |
Thanks for the correction I used the syntax example used in example script . this unified publish was Franz's idea . https://github.com/gc-os-ai/openml-project-dev/issues/8 |
initially
API