Cache cross sections according to the hash of download-xs.sh script #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
approved these changes
Dec 31, 2025
Member
shimwell
left a comment
shimwell
left a comment
There was a problem hiding this comment.
this is a good idea, particularly useful if / when we update the nuclear data
GuySten
added
the
Merging Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the cross sections cache does not depend on the download-xs.sh script so a change in the script does not invalidate the cache.
So if we change the download-xs.sh script to download more data or download different data this will not be reflected in the test workflow.
This PR change this behavior to use the hash of this file in the cache so a change in the script will invalidate the cache.
You can find more information here.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)