Skip to content

Conversation

@saraburns1
Copy link
Contributor

When unit analytics button is active, clicking the subsection analytics button should deeactivate the unit button and reset sidebar to subsection dashboards
When subsection analytics button is active, clicking it again should deactivate the subsection button and reset the sidebar to course dashboards

Screen.Recording.2025-12-01.at.4.26.23.PM.mov

Closes openedx/wg-build-test-release#542

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.92%. Comparing base (9d50d2e) to head (26f354b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/SubSectionAnalyticsButton.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   48.50%   47.92%   -0.58%     
==========================================
  Files          15       15              
  Lines         334      338       +4     
  Branches       64       66       +2     
==========================================
  Hits          162      162              
- Misses        162      166       +4     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

export function SubSectionAnalyticsButton({ subsection }: { subsection: SubSection }) {
const {
activeBlock, sidebarOpen, setActiveBlock, setSidebarOpen,
setFilterUnit,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verifying this exists (it does)

setFilterUnit: (value: Block | null) => {
state.filterUnit.set(value);
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test failure] TC-00314: In-unit analytics button still selected when selecting the subsection icon

3 participants