Allow custom ports and environment #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment variables Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
…tions Add Copilot instructions for repository
…urable Make Caddy container ports configurable via environment variables
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
- Reverted previous implementation that read from ShinyProxy spec - Now reads environment variables from operator's environment with SHINYPROXY_ENV_ prefix - Environment variables are passed to ShinyProxy container with prefix stripped - This allows using docker-compose env files for secrets without plain text in configs - Added comprehensive documentation with examples Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
- Validate that target key is not empty after stripping prefix - Validate that values don't contain newline characters (security) - Log warnings for invalid environment variables - Update documentation with validation rules Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
- Added Dockerfile.build for building in a container with Maven and JDK 21 - Added docker-compose.build.yml for easy Docker-based builds - Added devbox.json configuration for Devbox development environment - Added BUILD.md with comprehensive build instructions for all options - Users can now build without installing Maven/JDK locally Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
- Changed from 'mvn clean install' to 'mvn clean package -DskipTests' for faster builds - 'package' is sufficient for creating the JAR without installing to local repository - Updated Dockerfile.build, BUILD.md, and devbox.json consistently - Addresses user feedback on build command Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
…ld simply output the artifact. Removed the docker compose option.
… up mvn dependencies and for packaging without tests. Updated BUILD.md to reflect these changes.
…proxy Pass environment variables from operator to ShinyProxy Docker containers
…y caddy and shinyproxy still use the regular ports they expect.
…via secret Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
…y support Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
Co-authored-by: jaredlander <628977+jaredlander@users.noreply.github.com>
…ld-test Add GitHub Actions workflow for building and pushing Docker images to Azure Container Registry
…by shinyproxy-orchestraotr.
…RT_0 so that we can add additional config imports and spring.config.import is no longer a forbidden configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing Environment Variables to shinyproxy
This allows users to pass environment variables through shinyproxy-operator (via docker compose) to the shinyproxy container as requested in #66.
When setting the variable set it with a
SHINYPROXY_ENV_prefix. For example settingSHINYPROXY_ENV_TEST_VAR: test_valuewill result in the shinyproxy-operator container have an environment variable namedSHINYPROXY_ENV_TEST_VARwith a value oftest_valueAND the shinyproxy container will have an environment variable namedTEST_VARwith a value oftest_value.Setting Custom Ports
This allows users to specify ports for caddy using
SPO_CADDY_PORT_HTTPandSPO_CADDY_PORT_HTTPSas requested in #65. This will change the external ports for caddy but everything internally will still be on the standard 80/443 ports.Automatic Image Building
Added a GitHub Action to automatically build the operator image and push to a registry as set in the repo secretes.