Prevent crash when instrumenting background URLSession tasks
#1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielDemarco
requested review from
bryce-b,
nachoBonafonte and
vvydier
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #552 crash when instrumenting background
URLSessiontasks by detecting and skipping them based on their runtime class name.Summary
Background
URLSessiontasks crash if you attempt to assign a delegate to them after creation. The instrumentation was trying to assign aFakeDelegateto capture completion events onresume, which caused the app to crash.After digging deeper, background sessions require the delegate to be set when creating the session and don't support:
data(from:),upload(for:), etc.)To solve this problem, it was added an extension (
URLSessionTask.isBackground) that detects background tasks by checking their runtime class name against known background task classes.