feat: Add configuation options for MetricKit instrumentation #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beekhc
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
Contributor
Author
|
The failed macOS test appears to be unrelated to my changes, and passes locally. Maybe it's just flaky? |
2 tasks
beekhc
added a commit
to honeycombio/honeycomb-opentelemetry-swift
that referenced
this pull request
Dec 17, 2025
…strumentation instead of Honeycomb versions (#125) ## Which problem is this PR solving? Adds options to use upstream URLSession and MetricKit instrumentation. ## Short description of the changes The URLSession instrumentation defaults to true (using the upstream version), because the change should be invisible to our customers. I only left the old instrumentation in there for now in case there is some problem when customers upgrade, so they can switch back without waiting for us to make a new release. The MetricKit instrumentation defaults to false for now, because there are minor differences between the upstream version and ours. I have [a PR out](open-telemetry/opentelemetry-swift#1014) to iron out those differences. Once they are identical, we can switch this to default to true. Next time there's a major release, we should remove these options and remove our own versions of this instrumentation. ## How to verify that this has the expected result Smoke tests still pass with the new defaults. I have also tried them with the other values manually and verified they still work (with the expected changes to MetricKit telemetry). --- - [X] CHANGELOG is updated - [X] README is updated with documentation N/A ~- [ ] Update `honeycombLibraryVersion` in `Sources/Honeycomb/HoneycombVersion.swift`~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configuration options for MetricKit instrumentation, based on the existing URLSession instrumentation. I also added an overload so that this won't be a breaking change for any existing users.
The two initial configuration options are:
useAppleStacktraceFormat-- to force using Apple's format for JSON stacktraces instead of the new OTel onetracer-- to allow using a custom tracer, the same as in the URLSession configTests were added for all new options.