Add synchronous processing and HTTP status code validation to OtlpHttpTraceExporter #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devjoonn
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
|
|
Author
|
@bryce-b @nachoBonafonte @vvydier @ArielDemarco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTLP HTTP Trace Exporter had an issue where it always returned .success regardless of the actual HTTP request result. This prevented callers from detecting failures even when network errors or 4xx/5xx responses occurred.
To fix this, the exporter now waits for the HTTP request to finish and returns the correct result based on the actual response. HTTP status code validation, error messages, and request header handling were also improved.
With this change, the exporter properly returns .failure for network issues or non-2xx responses, and failed spans are safely re-added for retry.