Implement db.query.summary for SqlClientAttributesExtractor #15548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
db-query-summary-sql
branch
5 times, most recently
from
f299e7c to
c5970ae
Compare
trask
commented
Dec 6, 2025
Comment on lines
+155
to
+157
| equalTo( | ||
| DbAttributes.DB_QUERY_SUMMARY, | ||
| emitStableDatabaseSemconv() ? "CALL" : null)), |
Member
Author
There was a problem hiding this comment.
should this be CALL NEXT VALUE?
Contributor
There was a problem hiding this comment.
I think it would be better to call it CALL Customer_SEQ or maybe CALL NEXT VALUE FOR Customer_SEQ. Having the summary contain the sequence name feels more informative. The sample summaries in the spec also contain the table names.
20 tasks
trask
force-pushed
the
db-query-summary-sql
branch
3 times, most recently
from
e761302 to
69592b0
Compare
trask
force-pushed
the
db-query-summary-sql
branch
from
69592b0 to
ef34cbd
Compare
Pass the caught exception as the cause when rethrowing UnsupportedOperationException to avoid compilation error when -Werror is enabled.
When SQL query text cannot be parsed (e.g., invalid SQL or non-SQL text), the span name was incorrectly falling back to server.address instead of the default 'DB Query' name. According to semconv, server.address should only be used as part of the target when combined with an operation (e.g., 'SELECT localhost'). When there is no operation, the fallback should be db.system.name or the default span name. This change ensures that server.address is only used when we have a valid operation to combine it with, preventing span names like 'localhost' when the SQL cannot be parsed. Fixes failing tests in: - :instrumentation:jdbc:javaagent:testStableSemconv - :instrumentation:jdbc:library:testStableSemconv - :instrumentation:cassandra:cassandra-3.0:javaagent:testStableSemconv
Per the stable database semantic conventions, when neither operation nor target are available, the span name should be db.system.name. Updated the test to expect 'other_sql' (the db.system.name value) for stable semconv, while keeping 'DB Query' for old semconv to maintain backward compatibility.
- Fix computeSpanNameStable to return DEFAULT_SPAN_NAME instead of null when db.system is null - Include server address in target fallback even when no operation exists - Fix SqlStatementSanitizerTest to use getQueryText() instead of deprecated getFullStatement() Resolves test failures in DbClientSpanNameExtractorTest where span names were expected but null was returned.
trask
force-pushed
the
db-query-summary-sql
branch
from
ef34cbd to
a93e84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.