Using ruff for linting #03#81
Merged
codie3611 merged 1 commit intoopen-lasso-python:developfrom May 23, 2025
Merged
Conversation
Contributor
Author
|
@codie3611 Please review this, if you are available. |
codie3611
approved these changes
May 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refines the Ruff linter configuration and updates several import statements from relative to absolute paths to improve module clarity and consistency.
- Updated Ruff linting rules in pyproject.toml
- Changed relative import paths to absolute paths across multiple modules
- Improved import consistency in various dimensions of the codebase
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lasso/dyna/d3plot_header.py | Updated relative imports to absolute imports for binary buffering and logging. |
| src/lasso/dyna/d3plot.py | Updated all relative imports to absolute imports to enhance namespace clarity. |
| src/lasso/dimred/svd/subsampling_methods.py | Converted relative import statements to absolute paths. |
| src/lasso/dimred/hashing.py | Updated relative import of a math utility to its new absolute module path. |
| src/lasso/dimred/dimred_run.py | Changed relative imports to absolute ones in the dimensionality reduction runner. |
| src/lasso/diffcrash/run.py | Updated logging import from relative to absolute for improved clarity. |
| src/lasso/diffcrash/diffcrash_run.py | Switched commented-out relative import to an absolute import format. |
| pyproject.toml | Uncommented specific Ruff lint rules to enforce pycodestyle warnings, Pyflakes errors, and tidy imports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ruff lint select rules. This pull request includes follow-up modifications and refinements related to the integration of Ruff, a linter for Python. Updated rules in
pyproject.toml:W– pycodestyle warnings (e.g., extra spaces, indentation issues)F– Pyflakes errors (e.g., unused imports, undefined variables)TID– flake8-tidy-imports (checks for banned or misplaced imports)