Replace os.path with pathlib.Path in diffcrash#74
Merged
codie3611 merged 1 commit intoopen-lasso-python:developfrom Apr 11, 2025
saudzahirr:refactor/use_pathlib_in_diffcrash
Merged
Replace os.path with pathlib.Path in diffcrash#74codie3611 merged 1 commit intoopen-lasso-python:developfrom saudzahirr:refactor/use_pathlib_in_diffcrash
os.path with pathlib.Path in diffcrash#74codie3611 merged 1 commit intoopen-lasso-python:developfrom
saudzahirr:refactor/use_pathlib_in_diffcrash
Conversation
Contributor
Author
|
@codie3611 Please review this, if you are available. |
codie3611
approved these changes
Apr 11, 2025
Contributor
codie3611
left a comment
codie3611
left a comment
There was a problem hiding this comment.
Great work, I also prefer the Path. It is so much better.
Contributor
Author
|
@codie3611 Please merge it as I don't have merge rights. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the code in
diffcrashto replace all instances ofos.pathwithpathlib.Path. The use of os.path is considered less modern compared to pathlib.Path, which was introduced inPython 3.4. pathlib is now the preferred way to handle filesystem paths in modern Python code.