-
Notifications
You must be signed in to change notification settings - Fork 31
chore: replace mypy with ty #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
Summary of ChangesHello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on migrating the project's type checking infrastructure from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 97.89% 97.84% -0.05%
==========================================
Files 39 40 +1
Lines 1849 1855 +6
==========================================
+ Hits 1810 1815 +5
- Misses 39 40 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully replaces mypy with ty for static type checking. The changes are well-executed and cover all necessary adjustments, including updating the pre-commit configuration, modifying pyproject.toml to switch the dependency and configuration, and updating type ignore comments in the codebase to be compatible with ty. It's good to see that in some cases, ignore comments could be removed, indicating that ty handles certain type situations more effectively. The uv.lock file has also been updated to reflect these dependency changes. Overall, this is a solid chore update that modernizes the project's tooling.
|
While I love what the Astral team has been putting out recently, I'm in favor of waiting a bit more for ty to mature. I am not sure there is a clear benefit for us switching right now, but happy to discuss it more. |
This PR