Fix table column width overflow in CV skills section#7
Conversation
Co-authored-by: oonis <30103396+oonis@users.noreply.github.com>
Co-authored-by: oonis <30103396+oonis@users.noreply.github.com>
Co-authored-by: oonis <30103396+oonis@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes text overflow issues in the CV by adjusting table column widths and header spacing. The changes address a 79.55pt overflow in the skills section table and a minor 1.46pt header overflow.
Key Changes:
- Reduced skills table second column width from
0.9\textwidthto0.73\textwidthto prevent overflow - Adjusted header spacing by changing separators to use smaller spacing commands
- Added build artifacts (
cv.pdf,*.png) to.gitignore
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
awesome-cv.cls |
Updated default spacing for header icons and social separators, and reduced skills table column width to fix overflow |
cv.tex |
Overrode social separator spacing to match the class file update |
.gitignore |
Added generated PDF and PNG files to prevent committing build artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -735,7 +735,7 @@ | |||
| \begin{center} | |||
| \setlength\tabcolsep{1ex} | |||
| \setlength{\extrarowheight}{0pt} | |||
There was a problem hiding this comment.
The magic number 0.73 lacks documentation explaining how it was calculated. According to the PR description, this accounts for tabcolsep spacing and the first column width, but the calculation isn't shown in a comment.
Consider adding a comment explaining the calculation:
% Column width calculation: 0.73 = (1.0 - (2*tabcolsep + first_column_width)/\textwidth)
% where tabcolsep=1ex (set on line 736) and first column uses 'r' (right-aligned, minimal width)
\begin{tabular*}{\textwidth}{@{\extracolsep{\fill}} r L{\textwidth * \real{0.73}}}This would help future maintainers understand why this specific value was chosen and how to adjust it if needed.
| \setlength{\extrarowheight}{0pt} | |
| \setlength{\extrarowheight}{0pt} | |
| % Column width calculation: 0.73 = (1.0 - (2*tabcolsep + first_column_width)/\textwidth) | |
| % where tabcolsep=1ex (set on line 736) and first column uses 'r' (right-aligned, minimal width) |
|
|
||
| % Social information separator | ||
| \renewcommand{\acvHeaderSocialSep}{\quad\textbar\quad} | ||
| \renewcommand{\acvHeaderSocialSep}{\enskip\textbar\enskip} |
There was a problem hiding this comment.
This override in cv.tex is now redundant since the same change was made to the default value in awesome-cv.cls (line 420). The class file already defines \acvHeaderSocialSep with this exact value, so this \renewcommand has no effect.
Consider removing this line to avoid redundancy and rely on the class file's default value.
| \renewcommand{\acvHeaderSocialSep}{\enskip\textbar\enskip} |
The CV had text overlapping in the skills section due to a table column width calculation that caused a 79.55pt overflow. The second column was set to
0.9\textwidthwithout accounting for table separators and the first column width.Changes
awesome-cv.cls): Reduced second column width from0.9\textwidthto0.73\textwidthto account fortabcolsepspacingawesome-cv.cls,cv.tex): Changed social separator from\quad\textbar\quadto\enskip\textbar\enskipand icon separator from\spaceto\hspace{0.5ex}to reduce minor 1.46pt header overflow.gitignore): Addedcv.pdfand*.pngWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.