-
Notifications
You must be signed in to change notification settings - Fork 78
Add Cadence Computation Profiling Guide #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
turbolent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this up! Some small comments, but looks great overall, the step-by-steps instructions and troubleshooting info is very useful 👍
|
|
||
| ## Using Source File Pragmas | ||
|
|
||
| The `#sourceFile` pragma improves report readability by associating your code with meaningful file paths. Without it, reports show generic identifiers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if sourceFile pragma is supported when profiling. Maybe it only applies to computation reports? I didn't add explicit support for source file pragmas when implementing profiling, but maybe this already works automatically somehow?
Maybe double check availability, and point out if it only applies to reporting. If it's not supported for profiling yet, let's add it, it looks like a nice feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it only applies to reporting. Good catch. I'll adjust the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it gets added we can update the doc.
Co-authored-by: Bastian Müller <bastian@turbolent.com>
No description provided.