Open
Conversation
onesine
reviewed
Mar 7, 2023
| return item.label.split("").map((label, idx) => { | ||
| if (idx >= start && idx < end) { | ||
| return ( | ||
| <span key={idx} className={`font-bold text-${primaryColor}-500`}> |
Owner
There was a problem hiding this comment.
Unfortunately, you can't use string interpolation like text-${primaryColor}-500 as described in the Tailwind documentation https://tailwindcss.com/docs/content-configuration#dynamic-class-names
const getTextColor = useMemo(() => {
if (COLORS.includes(primaryColor)) {
return THEME_DATA.text[primaryColor as keyof typeof THEME_DATA.text];
}
return THEME_DATA.text[DEFAULT_THEME];
}, [primaryColor]);
You can use this code to get the color of the text based on primaryColor.
The code (here) contains other examples.
| options={options} | ||
| /> | ||
| ); | ||
| return <Select value={animal} onChange={this.handleChange} options={options} />; |
Owner
There was a problem hiding this comment.
It's true that it's fewer lines, but I find it's more readable on multiple lines.
Collaborator
Author
There was a problem hiding this comment.
Oops sorry for that, sorry. I guess this was changed because of auto formatting (probably Prettier Extension) in my vscode settings 😅
| options={options} | ||
| /> | ||
| ); | ||
| return <Select value={animal} onChange={handleChange} options={options} />; |
| onChange={handleChange} | ||
| options={options} | ||
| /> | ||
| <Select primaryColor={"indigo"} value={animal} onChange={handleChange} options={options} /> |
Owner
|
Thank you @cha2hyun for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature for issue #18, issue #19
Code inspeciton is needed 👍