Fix umfPoolDestroy to destroy providers in the right order#794
Merged
ldorau merged 1 commit intooneapi-src:mainfrom Oct 14, 2024
Merged
Fix umfPoolDestroy to destroy providers in the right order#794ldorau merged 1 commit intooneapi-src:mainfrom
ldorau merged 1 commit intooneapi-src:mainfrom
Conversation
bratpiorka
approved these changes
Oct 14, 2024
ldorau
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our current implementation of the
umfPoolDestroydestroys tracking and the upstream memory providers in the wrong order. The tracking memory provider is a wrapper on top of the upstream memory provider and as a result thetrackingFinalizefunction might use upstream memory provider. I found this issue while working on the #736.Checklist