Added cross-platform paths for Darwin and Windows #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the paths used in the https://github.com/casimir/xdg-go project. The existing default paths are maintained on any other platform, and have been extracted to the `Default` platform class.
Fixed tests, changed BaseDirectory to work with them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the paths used in the https://github.com/casimir/xdg-go project.
The existing default paths are maintained on any other (*nix) platform, and have
been extracted to the
Defaultplatform class.I've not changed tests at all, so that would need visiting if you'd consider merging.
I'm not sure if this fits how you want to develop the library, and tests were already failing on
Windows due to the path separators being different than expected. Let me know if you have
suggestions for how this might fit with what you want to do.