-
Notifications
You must be signed in to change notification settings - Fork 0
feat(react-native-devtools): add Electrobun desktop app with Metro debugger #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ohah
wants to merge
4
commits into
main
Choose a base branch
from
feat/react-native-devtools-electrobun
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bugger - Add @ohah/chrome-remote-devtools-react-native-devtools package (Electrobun + React + Vite) - Metro debugger only: Metro URL settings, target list, iframe DevTools UI - CORS workaround: fetchUrl RPC from main process; window controls RPC (close/minimize/maximize) - Custom title bar (hidden native): drag region, Refresh/Settings, then window controls (Tauri order) - Permissions-Policy for clipboard in dev server; iframe allow clipboard-read/write * - Port 2420; dev script REACT_NATIVE_DEVTOOLS service; AGENTS.md package list
Integration Tests0 tests 0 ✅ 0s ⏱️ Results for commit 7780989. ♻️ This comment has been updated with latest results. |
📊 Test Results✅ Test Status: PASSED📸 ScreenshotsScreenshots are available as artifacts. Download them here. Artifact name: Screenshot files
|
…ument codesign - Disable maximize-to-restore (toggleMaximizeWindow) to avoid CEF freeze - Minimize from maximized: unmaximize then minimize - Fix fetchUrl RPC handler type (params?: unknown) for defineRPC schema - Document macOS codesign/notarize in README and electrobun.config comments
- Set app.name and identifier in electrobun.config.ts - Set index.html title to React Native DevTools
…tion - Title bar drag region, nav buttons, window controls (min/max/close) - Mainview styles (index.css) and entry (main.tsx) - scripts/dev.ts: REACT_NATIVE_DEVTOOLS service, package.json deps and workspace
📱 Maestro iOS Test Results❌ FAILED Maestro iOS tests have completed. Check the workflow run for details. |
📱 Maestro Android Test Results❌ FAILED Maestro Android tests have completed. Check the workflow run for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/react-native-devtools-electrobun
Purpose
Add a desktop app for React Native developers that runs on Electrobun and provides Metro debugger (Chrome DevTools) only, aligned with the existing Inspector (Tauri) layout and dev workflow.
Work content
New package:
@ohah/chrome-remote-devtools-react-native-devtoolsCORS and window controls
fetchUrl) to avoid CORS in the renderer.getMetroTargetsuses this when available.closeWindow,minimizeWindow,toggleMaximizeWindow).Clipboard and Permissions-Policy
allow="clipboard-read *; clipboard-write *"for Copy in DevTools. Vite dev server and preview sendPermissions-Policy: clipboard-read=(*), clipboard-write=(*)so the top-level document allows clipboard for itself and iframes.Monorepo integration
scripts/dev.tsincludes a REACT_NATIVE_DEVTOOLS service (default on) that runs the app with HMR. AGENTS.md updated with the new package and flow.How to test
bun run dev(or setINCLUDE_REACT_NATIVE_DEVTOOLS=falseto disable). Open the React Native DevTools URL (e.g. from Service URLs).Additional info
Electrobun (Metro debugger–only) is also tracked in the Issues tab for visibility (see #130).
Relates to #128
Relates to #130