Changes for #12293 - split CTD and DO cabled streams.#34
Open
danmergens wants to merge 1 commit intooceanobservatories:masterfrom
Open
Changes for #12293 - split CTD and DO cabled streams.#34danmergens wants to merge 1 commit intooceanobservatories:masterfrom
danmergens wants to merge 1 commit intooceanobservatories:masterfrom
Conversation
- updated and sorted stream_metadata - added time range utility, extract_time - added tests to verify computation of dissolved oxygen products - corrected metbk hourly test Change-Id: I954a5d2ed5c11244a7f765694d54f09264eb42ec
renegelinas
approved these changes
Nov 21, 2017
Contributor
renegelinas
left a comment
renegelinas
left a comment
There was a problem hiding this comment.
I like the alphabetizing of stream_metadata.csv!
tlfish3638
reviewed
Nov 21, 2017
Contributor
tlfish3638
left a comment
tlfish3638
left a comment
There was a problem hiding this comment.
I don't know this code well enough to offer truly useful feedback but I didn't see anything that concerns me.
Contributor
Author
|
Thanks for the reviews. It's not critical that this get updated. There are some nice test case additions that just show that the updates are working properly. |
Contributor
|
what's the unit test failure about? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I954a5d2ed5c11244a7f765694d54f09264eb42ec