Make the project build using the committed lock dir#185
Draft
Leonidas-from-XIV wants to merge 1 commit intoocaml-dune:mainfrom
Draft
Make the project build using the committed lock dir#185Leonidas-from-XIV wants to merge 1 commit intoocaml-dune:mainfrom
Leonidas-from-XIV wants to merge 1 commit intoocaml-dune:mainfrom
Conversation
Signed-off-by: Marek Kubica <marek@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there is a
lock.dirin the project and Dune can build the project with package management, this changes the Dockerfile to usedune pkgfor building it.Currently it is experiencing some kind of issue:
I do not experience the issue outside the Docker container and it works when using autolocking so there seems to be some kind of issue with the lock directory.