simplehttp: Update event loop usage for Python 3.11+#196
Closed
RytoEX wants to merge 1 commit intoobsproject:masterfrom
Closed
simplehttp: Update event loop usage for Python 3.11+#196RytoEX wants to merge 1 commit intoobsproject:masterfrom
RytoEX wants to merge 1 commit intoobsproject:masterfrom
Conversation
Member
Author
Contributor
|
finally:
logging.info('Exiting application.')
while applicationTask.cancel(): # Shuts down the HTTP server
loop.call_soon(loop.stop)
loop.run_forever()
threadPool.shutdown() # Shuts down the running thread pool
loop.close()I however do not guarantee it is the best way of doing it, ideally, we shouldn't be using run_forever at all, but this is another question. |
Member
Author
|
From off-thread discussion, @tt2468 will take a look at this later. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update event loop usage for Python 3.11+.
Motivation and Context
Corrects/Updates event loop usage to address this warning:
However, this surfaces new errors when quitting the application:
Adding a
loop.close()to the end of thefinallyblock resolves this.However, other errors persist:
However, these only occur on exit, and I'm not familiar enough with Python asyncio dev to address them.
Python 3.10:
https://docs.python.org/3.10/library/asyncio-eventloop.html#asyncio.get_event_loop
https://docs.python.org/3.10/library/asyncio-eventloop.html#hello-world-with-call-soon
Python 3.11:
https://docs.python.org/3.11/library/asyncio-eventloop.html#asyncio.get_event_loop
https://docs.python.org/3.11/library/asyncio-eventloop.html#hello-world-with-call-soon
Python 3.14:
https://docs.python.org/3.14/library/asyncio-eventloop.html#asyncio.get_event_loop
https://docs.python.org/3.14/library/asyncio-eventloop.html#hello-world-with-call-soon
How Has This Been Tested?
Tested locally on Windows with Python 3.11 and 3.14.
Types of changes
Checklist: