Detach fields in-order after consensus match#843
Detach fields in-order after consensus match#843manopapad wants to merge 4 commits intonv-legate:branch-24.03from
Conversation
|
So if I'm understanding this correctly, this version effectively does a consensus match to see which fields to recycle, and when it does that, then it see which fields can be recycled across all the shards, and it does the ordered detach at that point right before it recycles the IDs in the same way across all the shards. If that's accurate, it definitely seems better than doing the unordered detach operations. One obvious idea to play around with here is whether we can pipeline this process. For example, if we shrunk the number of allocations between consensus match calls down to 16 (from the default 32?), but then instead of blocking to wait for the result, we just saved the result for the next 16 allocation calls to be done, and then look at the result of the previous consensus match to see if we can recycle any of those fields? Seems like that might be better than exposing the latency of the consensus match. We could also probably make the pipeline three stages deep:
|
Otherwise we end up doing runtime work in a detructor, which causes CFII to deadlock.
No description provided.