Fix dark mode accessibility and card layout consistency on Ingest page#52
Open
IshankAggarwal09 wants to merge 1 commit intonumfocus:mainfrom
Open
Fix dark mode accessibility and card layout consistency on Ingest page#52IshankAggarwal09 wants to merge 1 commit intonumfocus:mainfrom
IshankAggarwal09 wants to merge 1 commit intonumfocus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes dark mode accessibility issues and a layout inconsistency on the Ingest page.
Text and UI elements were previously using hardcoded light-theme colors, which caused low contrast in dark mode and made the bottom border of the second ingest card (“Discover & Ingest by Keywords”) appear missing.
The changes ensure consistent theming using existing CSS variables, improve WCAG color contrast, and correct spacing so both ingest cards render correctly without visual overlap.
No new dependencies are required.
Fixes #49
Type of change
How Has This Been Tested?
The changes were tested manually in both light and dark modes.
Verified color contrast using browser dark mode and WCAG contrast checks
Confirmed both ingest cards display consistent borders and spacing
Ensured buttons no longer overlap card borders
Tested form interactions (disabled state, loading state, success/error messages)
Manual UI testing (light mode)
Manual UI testing (dark mode)
I have added the unit tests (if applicable)
Test Configuration :
Checklist:
(UI-only change; no automated tests applicable)
(Not applicable)
Before
After