fix(a11y, ui): make copy commands buttons always visible#998
fix(a11y, ui): make copy commands buttons always visible#998IdrisGit wants to merge 5 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughCopy buttons in Execute.vue, Install.vue and SkillsModal.vue were made permanently visible by removing Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app/components/Terminal/Execute.vue (1)
71-74: Drop per-button focus-visible utility; rely on the global button focus style.The inline
focus-visible:outline-accent/70on a<button>conflicts with the global focus-visible rule inapp/assets/main.css. Please remove it to keep focus styling consistent.Proposed change
- class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95 focus-visible:outline-accent/70" + class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95"Based on learnings: focus-visible styling for buttons and selects is applied globally via main.css; avoid per-element focus-visible utility classes like
focus-visible:outline-accent/70.app/components/Terminal/Install.vue (1)
124-127: Remove per-button focus-visible utilities and rely on the global rule.These three buttons still include
focus-visible:outline-accent/70, which conflicts with the project’s global focus-visible styling inapp/assets/main.css.Proposed change
- class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95 focus-visible:outline-accent/70" + class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95"- class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95 focus-visible:outline-accent/70" + class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95"- class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95 focus-visible:outline-accent/70" + class="px-2 py-0.5 font-mono ms-auto text-xs text-fg-muted bg-bg-subtle/80 border border-border border-solid rounded transition-colors duration-200 hover:(text-fg border-border-hover) active:scale-95"Based on learnings: focus-visible styling for buttons and selects is applied globally via main.css; avoid per-element focus-visible utility classes like
focus-visible:outline-accent/70.Also applies to: 186-189, 231-233
|
I like it. I just feel the eye has to travel from the button to its related content. How could this be mitigated ? |
@graphieros fair point, I think quick way would be to remove the right align and show the button in it's original place, later we can think about a better position or if you have any ideas.
|
|
I think we need to know what others think. The initial intention was to avoid cluttering the content. |
|
@graphieros yeah that makes sense, I will try with icons and post screenshots here |
a69fdd0 to
905a187
Compare
|
Ok after trying few things and researching other platforms:
|
905a187 to
17c4dd8
Compare

There are two issues I am trying to solve in this PR:
I was confused where the copy button was and when I decided to highlight using cursor and copy manually that I saw the copy button popup.
screen recording of the issue and the fix
copy_button_compressed.mp4
side note: as a side effect it also fixes an issue on mobile where it's very hard to know where the copy command, since the opacity of the button changes based on the hover state.