Skip to content

fix: collapsing behavior and padding#952

Merged
43081j merged 1 commit intonpmx-dev:mainfrom
MhemedAbderrahmen:fix/collapsible-section-animation
Feb 4, 2026
Merged

fix: collapsing behavior and padding#952
43081j merged 1 commit intonpmx-dev:mainfrom
MhemedAbderrahmen:fix/collapsible-section-animation

Conversation

@MhemedAbderrahmen
Copy link
Contributor

The current implementation already have the animation but it requires the default open state to be set.

  • This PR fixes the collapse animation
  • Removed the extra padding (p-1) It messes up with the collapse and some item's content will stick out, the already handle their own spacing so IMHO it's unnecessary.

Before

collapse-broken.mp4

After

collapse-fixed.mp4

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 4:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 4:02pm
npmx-lunaria Ignored Ignored Feb 4, 2026 4:02pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The CollapsibleSection.vue component has been updated with CSS layout adjustments. A grid-rows-[1fr] class was added to the content container to define an explicit flexible row layout. Additionally, the padding class (p-1) was removed from the inner content wrapper, reducing internal spacing around the slotted content. These are purely styling and layout modifications with no changes to the component's behaviour or public API.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the changes: fixing collapse animation and removing unnecessary padding (p-1) that interfered with the collapsing behaviour. The description is directly related to the code changes in CollapsibleSection.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros self-requested a review February 4, 2026 16:30
Copy link
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@43081j 43081j added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 820662c Feb 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants