Skip to content

style: use logical properties for RTL support#946

Open
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:style/use-logical-properties-for-rtl
Open

style: use logical properties for RTL support#946
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:style/use-logical-properties-for-rtl

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 4, 2026

it is causing warning in cli.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 3:09pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Feb 4, 2026 3:09pm
npmx-lunaria Ignored Ignored Feb 4, 2026 3:09pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the stylesheet utility class applied to a sidebar container in the package page component. The change replaces the physical padding property pr-2.5 (padding-right) with the logical padding property pe-2.5 (padding-end). This adjustment enables the layout to automatically adapt to different text directions, such as right-to-left languages, without requiring separate style rules. The file contains a single line modification affecting the directional spacing of the container element.

Possibly related PRs

  • npmx-dev/npmx.dev PR 917: Also updates CSS utilities from physical properties (pr) to logical properties (pe) within the same component file, following a consistent pattern of internationalisation-aware styling.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is vague and contains a typo ('casing' instead of 'causing'), but it does relate to the changeset which addresses style warnings. Clarify the specific warning message and explain why switching to logical properties (RTL support) resolves it. Correct the typo for clarity.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant