Skip to content

fix(ui): default data-theme on SSR#939

Open
wojtekmaj wants to merge 1 commit intonpmx-dev:mainfrom
wojtekmaj:default-data-theme
Open

fix(ui): default data-theme on SSR#939
wojtekmaj wants to merge 1 commit intonpmx-dev:mainfrom
wojtekmaj:default-data-theme

Conversation

@wojtekmaj
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 4, 2026 13:34
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 1:36pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 1:36pm
npmx-lunaria Ignored Ignored Feb 4, 2026 1:36pm

Request Review

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/app.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a Flash of Unstyled Content (FOUC) issue during server-side rendering by setting a default data-theme attribute to 'light' on the HTML element.

Changes:

  • Adds a hardcoded data-theme: 'light' attribute to the HTML element via useHead() in app.vue
  • Includes a comment explaining that this is intended to prevent a white page flash during initial load

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The pull request introduces a new data-theme attribute to the HTML head element in app/app.vue, configured with a default value of 'light'. This addition ensures that a theme is applied during the initial page load before user preferences are determined, preventing a visual flash of white and establishing the correct appearance for users with white-mode settings from the outset. The change consists of eight lines added with no lines removed, and does not alter other head attributes or control flow logic.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author. Add a pull request description explaining the changes, the problem being solved, and why a default data-theme attribute is necessary for SSR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant