Skip to content

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Feb 4, 2026

This PR adds the cookie policy page including:

  • change AppFooter component layout, on sm the links displayed below the build_at entry (arggg) can go to another PR (or maybe not)

TODO:

  • add cookie policy to mobile menu
  • use NuxtTime to display Last updated
  • add logic to store Last updated at app config (maybe using git?)
  • add es.json
  • handle hydration missmatch
  • review session cookies: rigth now using sign-in (not yet sure the purpose for these 2 cookies at npmx.dev: __vdpl and h3)

/cc @danielroe if you want to do some change

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Building Building Preview, Comment Feb 4, 2026 6:23pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 6:23pm
npmx-lunaria Ignored Ignored Feb 4, 2026 6:23pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/components/AppFooter.vue 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@danielroe
Copy link
Member

__vdpl - this Vercel skew protection, tracking which deployment to fetch JS from, in case a new deployment happens while the user is on it. it doesn't track the user.

h3 - this is our session cookie which stores the oauth access token (for atmosphere connections)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants