Skip to content

chore: bump vue-data-ui from 3.14.10 to 3.15.0#1455

Merged
graphieros merged 3 commits intonpmx-dev:mainfrom
graphieros:main
Feb 13, 2026
Merged

chore: bump vue-data-ui from 3.14.10 to 3.15.0#1455
graphieros merged 3 commits intonpmx-dev:mainfrom
graphieros:main

Conversation

@graphieros
Copy link
Contributor

Accessibility fixes:

  • target area for range handles is now a11y compliant, closes TrendsChart and/or LineChart components with a11y issues #1348
  • increased the default width of range handles and added a discrete 'grab' icon
  • clickable items now with default cursor
  • alt copy feature is now implementable (left some comments in the code when that is discussed and ready to be worked on)

VueUiXy Render issue on iOs16

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 6:11am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 6:11am
npmx-lunaria Ignored Ignored Feb 13, 2026 6:11am

Request Review

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/TrendsChart.vue 50.00% 0 Missing and 1 partial ⚠️
app/components/Package/VersionDistribution.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

This PR updates chart UI scaffolding in TrendsChart.vue and VersionDistribution.vue and bumps the vue-data-ui dependency from 3.14.10 to 3.15.0. It adds altCopy button placeholders (titles and commented callback), introduces minimap handle properties (handleWidth, handleBorderColor, handleType) for main and zoom minimaps, increases the refresh button horizontal offset from 2rem to 4rem, and adds UI slots/templates and an accessibility icon slot related to the alt-copy feature.

Possibly related PRs

  • fix: tweak versions chart config #1365: Modifies VersionDistribution.vue chart configuration (userOptions.buttonTitles and callbacks) — closely related to the button/callback changes present here.

Suggested reviewers

  • danielroe
  • shuuji3
  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, mentioning a11y fixes, range handle improvements, and iOS 16 polyfill support that align with the code changes.
Linked Issues check ✅ Passed The pull request addresses both linked issues: #1348 (a11y compliance with increased handle width and grab icon) and #1391 (Object.groupBy polyfill for iOS 16 support via vue-data-ui update).
Out of Scope Changes check ✅ Passed All changes are within scope: TrendsChart and VersionDistribution modifications address a11y issues, and the vue-data-ui dependency update addresses the iOS 16 rendering issue.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/components/Package/TrendsChart.vue (1)

1426-1434: ⚠️ Potential issue | 🟠 Major

Confirm: minimap handleWidth does not control touch target on mobile.

The inline comment in both TrendsChart.vue and VersionDistribution.vue explicitly states "does not affect the size of the touch area"—confirming your concern. The 40px mobile value appears intended for accessibility but doesn't enlarge the actual pointer target. Check vue-data-ui 3.15.0 for documented alternatives (e.g. a hit-area or selectionRadius adjustment for touch sizing); if unavailable, a wrapper element may be needed to meet the 40px touch target requirement.

@graphieros
Copy link
Contributor Author

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/components/Package/TrendsChart.vue (1)> 1426-1434: ⚠️ Potential issue | 🟠 Major

Confirm: minimap handleWidth does not control touch target on mobile.
The inline comment in both TrendsChart.vue and VersionDistribution.vue explicitly states "does not affect the size of the touch area"—confirming your concern. The 40px mobile value appears intended for accessibility but doesn't enlarge the actual pointer target. Check vue-data-ui 3.15.0 for documented alternatives (e.g. a hit-area or selectionRadius adjustment for touch sizing); if unavailable, a wrapper element may be needed to meet the 40px touch target requirement.

Yields 100% Lighthouse score on the compare page on mobile & desktop

@graphieros graphieros added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit 3ce6ad9 Feb 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts fail to render on iOS 16 TrendsChart and/or LineChart components with a11y issues

2 participants