chore: bump vue-data-ui from 3.14.10 to 3.15.0#1455
chore: bump vue-data-ui from 3.14.10 to 3.15.0#1455graphieros merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR updates chart UI scaffolding in TrendsChart.vue and VersionDistribution.vue and bumps the vue-data-ui dependency from 3.14.10 to 3.15.0. It adds altCopy button placeholders (titles and commented callback), introduces minimap handle properties ( Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/components/Package/TrendsChart.vue (1)
1426-1434:⚠️ Potential issue | 🟠 MajorConfirm: minimap handleWidth does not control touch target on mobile.
The inline comment in both TrendsChart.vue and VersionDistribution.vue explicitly states "does not affect the size of the touch area"—confirming your concern. The 40px mobile value appears intended for accessibility but doesn't enlarge the actual pointer target. Check vue-data-ui 3.15.0 for documented alternatives (e.g. a hit-area or selectionRadius adjustment for touch sizing); if unavailable, a wrapper element may be needed to meet the 40px touch target requirement.
Yields 100% Lighthouse score on the compare page on mobile & desktop |
Accessibility fixes:
TrendsChartand/orLineChartcomponents with a11y issues #1348VueUiXy Render issue on iOs16