fix(ui): scrollbar stabilize width to prevent layout jumps and fix color#1038
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR standardises scrollbar styling: adds global scrollbar-color using CSS variables, enables Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/pages/package/[...package].vue (1)
1343-1349:⚠️ Potential issue | 🟡 MinorUse valid keyword values for
scrollbar-widthin Firefox.The property
scrollbar-widthonly accepts keyword values (auto,thin,none); numeric values like8pxare invalid and will be ignored. Replace withthinto ensure consistent scrollbar rendering.🔧 Proposed fix
.sidebar-scroll { scrollbar-gutter: stable; - scrollbar-width: 8px; + scrollbar-width: thin; scrollbar-color: transparent transparent; }
screen recording of the issue and fix
scrollbar_fix_compressed.mp4
note: this fix valid for only chrome (or webkit based browser) because width values don't work on Firefox and hence the issue doesn't happen.