chore: update i18n contributing guide#1030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe CONTRIBUTING.md was updated to expand localisation guidance. The "Adding a new locale" step now references both a Pluralization rule callback and a separate Plural Rules resource. Guidance was added under "Update translation" and "Adding translations" explaining placeholder usage, advising against string concatenation in templates, recommending the Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CONTRIBUTING.md (1)
348-348:⚠️ Potential issue | 🟡 MinorFix typo: “then English” → “the English”.
Minor grammar issue in the sentence about outdated translations.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
427-442: Consider clarifying the complex content example.The
i18n-texample references translation keys (terms_linkandprivacy_policy) that aren't shown in the JSON snippet on line 430. Contributors might find it clearer if the example included the complete JSON structure.📖 Suggested enhancement for clarity
+ **Example JSON:** + ```json - { "agreement": "I accept the {terms} and {privacy}." } + { + "agreement": "I accept the {terms} and {privacy}.", + "terms_link": "Terms of Service", + "privacy_policy": "Privacy Policy" + } ``` + **Example Vue template:** + ```vue <i18n-t keypath="agreement" tag="p"> <template `#terms`> <NuxtLink to="/terms">{{ $t('terms_link') }}</NuxtLink> </template> <template `#privacy`> <strong>{{ $t('privacy_policy') }}</strong> </template> </i18n-t> ```
This PR includes the following changes to CONTRIBUTING.md file: