-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
ci: Add WSL testing workflow for Windows #61254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
8609d36 to
f08c04c
Compare
| @@ -0,0 +1,199 @@ | |||
| name: Test Windows | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an existing windows workflow at https://github.com/nodejs/node/blob/main/.github/workflows/coverage-windows.yml.
We could name this as test-wsl to avoid name confusion, or merge the two into one workflow file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. That one seems to be running in a native Windows environment instead of WSL. We can add WSL env into that file tho
|
IMO testing on WSL is almost identical to testing on Linux. Any issues building would be a result of WSL bugs, not Node.js ones, and the built executable will function identically to the Linux one, right? |
FWIW we state this: Lines 139 to 145 in 01e44dc
|
|
@avivkeller @richardlau Thank you for letting me know that! Closing as not needed per BUILDING.md |
This commit introduces a new GitHub Actions workflow for running Node.js builds and tests within a Windows Subsystem for Linux (WSL) environment.
WSL is used by nearly 15-17% of developers as their development environment, and I believe we should add CI testing for it. However, since GitHub Actions would significantly increase build times, it might be better to add this to https://ci.nodejs.org/ instead.
Refs: https://survey.stackoverflow.co/2025/technology

I'd like to hear the subteam's thoughts on this approach.