Skip to content

Conversation

@watilde
Copy link
Contributor

@watilde watilde commented Jan 2, 2026

This commit introduces a new GitHub Actions workflow for running Node.js builds and tests within a Windows Subsystem for Linux (WSL) environment.

WSL is used by nearly 15-17% of developers as their development environment, and I believe we should add CI testing for it. However, since GitHub Actions would significantly increase build times, it might be better to add this to https://ci.nodejs.org/ instead.

Refs: https://survey.stackoverflow.co/2025/technology
image

I'd like to hear the subteam's thoughts on this approach.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2026
@watilde watilde force-pushed the ci-wsl branch 22 times, most recently from 8609d36 to f08c04c Compare January 2, 2026 12:34
@@ -0,0 +1,199 @@
name: Test Windows
Copy link
Member

@legendecas legendecas Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an existing windows workflow at https://github.com/nodejs/node/blob/main/.github/workflows/coverage-windows.yml.

We could name this as test-wsl to avoid name confusion, or merge the two into one workflow file.

Copy link
Contributor Author

@watilde watilde Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment. That one seems to be running in a native Windows environment instead of WSL. We can add WSL env into that file tho

@avivkeller
Copy link
Member

IMO testing on WSL is almost identical to testing on Linux. Any issues building would be a result of WSL bugs, not Node.js ones, and the built executable will function identically to the Linux one, right?

@richardlau
Copy link
Member

IMO testing on WSL is almost identical to testing on Linux. Any issues building would be a result of WSL bugs, not Node.js ones, and the built executable will function identically to the Linux one, right?

FWIW we state this:

node/BUILDING.md

Lines 139 to 145 in 01e44dc

[^3]: The Windows Subsystem for Linux (WSL) is not
supported, but the GNU/Linux build process and binaries should work. The
community will only address issues that reproduce on native GNU/Linux
systems. Issues that only reproduce on WSL should be reported in the
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
Windows binary (`node.exe`) in WSL will not work without workarounds such as
stdio redirection.

@watilde
Copy link
Contributor Author

watilde commented Jan 6, 2026

@avivkeller @richardlau Thank you for letting me know that! Closing as not needed per BUILDING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants