Added: __eq__ method for Mindmap and Node classes.#4
Open
drakes00 wants to merge 1 commit intonnako:mainfrom
Open
Added: __eq__ method for Mindmap and Node classes.#4drakes00 wants to merge 1 commit intonnako:mainfrom
drakes00 wants to merge 1 commit intonnako:mainfrom
Conversation
Mindmap are compared by recursively comparing their nodes. Nodes are compared by comparing some of their attributes (plaintext, hyperlink, imagepath, details) and then recursively comparing their children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mindmap are compared by recursively comparing their nodes. Nodes are compared by comparing some of their attributes (plaintext, hyperlink, imagepath, details) and then recursively comparing their children.
See #3 for details.
I was not able to compare Node.notes fields since it does not seem to exists.
I however added Node.imagepath to comparison.