changed integer types to their correct enum types #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a few locations integer typed variables where used where their corresponding enum would be a better choice.
The ape_socket.states struct had origially 4 uint8_t fields. That fits nice in memory. By changing this into enums, We get a better typechecking, but enums are int's which use more memory then uint8_t's. By 'packing' that struct, we can have the cake and eat it as well.
Apperently GCC/Clang does not handle #pragma packed and Visual studio does not handle __attribute__. These extra ifdef's should do the tricks. (only tested with gcc and clang on linux)
pahole with gcc gives:
struct {
enum ape_socket_flags flags; /* 108 1 */
enum ape_socket_proto proto; /* 109 1 */
enum ape_socket_type type; /* 110 1 */
enum ape_socket_state state; /* 111 1 */
} states; /* 108 4 */
pahole with clang gives:
struct {
public:
enum ape_socket_flags flags; /* 108 1 */
enum ape_socket_proto proto; /* 109 1 */
enum ape_socket_type type; /* 110 1 */
enum ape_socket_state state; /* 111 1 */
} states; /* 108 4 */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few locations integer typed variables where used where their corresponding enum would be a better choice.