Skip to content

Conversation

@mshafer-NI
Copy link
Collaborator

Renovate keeps trying to upgrade flake8-import-order, which we can't upgrade due to a breaking change that will require work to unblock.

@github-actions
Copy link
Contributor

Thank you for contributing! 👋

]
},
{
"matchPackageNames": ["/flake8-import-order/"], // we're not compatible with 0.19.0 yet due to #226
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkeryan, did I understand correctly that we can use comments in Renovate config files even if they aren't marked as json5 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

https://docs.renovatebot.com/configuration-options/

Note: Renovate supports JSONC for .json files and any config files without file extension (e.g. .renovaterc). We also recommend you prefer using JSONC within a .json file to using a .json5 file if you want to add comments.

Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@mshafer-NI mshafer-NI merged commit b76492b into ni:main Jan 23, 2026
@mshafer-NI mshafer-NI deleted the dev/set_renovate_to_not_upgrade_flake8-import-order branch January 23, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants