Add base and theme aware tokens for splitter bar#2869
Conversation
| actionRgbPartialColor: 'action-rgb-partial-color', | ||
| applicationBackgroundColor: 'application-background-color', | ||
| dividerBackgroundColor: 'divider-background-color', | ||
| splitterBackgroundColor: 'splitter-background-color', |
There was a problem hiding this comment.
I'm open to feedback about naming. I went with "divider" for a non-interactive border between panes and "splitter" for an interactive / draggable border between panes. Brandon indicated that this token is intentionally darker to convey its interactivity.
A few component libraries use "splitter" (Kendo, DevExtreme), but none of the major design systems that I checked do. We could also go with divider-interactive or divider-draggable or divider-enabled or something like that (the part after the dash would be a "state" in our token naming guidelines).
There was a problem hiding this comment.
Chatted offline about one idea of if the calendar event concept of static vs dynamic applies to the states here (I think dynamic events are ones that are draggable but I don't actually know). Could be divider-dynamic + dynamic-static or something. If there is something there we can go for it or any of the other proposals here. Don't feel strongly.
There was a problem hiding this comment.
Here is the thread where we discussed the "dynamic" / "static" terminology: #2310 (comment)
It does seem like we used the terms to mean "movable" vs "fixed in place" so I think it makes sense to use that here. And I'm ok with scrapping the "splitter" terminology since it doesn't seem to be broadly used.
So the approved proposal is divider-background-dynamic-color:
- component: divider
- part: background
- state: dynamic
- type: color
If I don't find time to update this today, feel free to push updates to the PR while I'm out.
There was a problem hiding this comment.
Note for implementor (jesse, me, or otherwise) please also update the comments to emphasize the text for this token and the calendar tokens, i.e.
'Background color for static calendar events' -> 'Background color for static, non-movable calendar events',
'Background color for dynamic calendar events', -> 'Background color for dynamic, movable calendar events',
'Interactive splitter background color', -> 'Background color for dynamic, movable splitters',
Pull Request
🤨 Rationale
We are working on making a resizable chat pane. Brandon provided guidance about how to style the draggable splitter bar. Some of the colors are not yet present in the design system.
👩💻 Implementation
🧪 Testing
Storybook inspection
✅ Checklist