Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't submit until all Angular upgrade PRs are queued up and ready.

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "major",
"comment": "Update to Angular 20",
"packageName": "@ni/eslint-config-angular",
"email": "7282195+m-akinc@users.noreply.github.com",
"dependentChangeType": "patch"
}
22,250 changes: 8,768 additions & 13,482 deletions package-lock.json

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions packages/eslint-config-angular/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ export const angularTypescriptConfig = defineConfig([
https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin/src/configs/recommended.json
*/

'@angular-eslint/component-class-suffix': 'error',
/*
Enabling this would require replacing DI constuctor parameters with fields initialized with `inject()`.
The new fields would have to be declared early/first in the class (other initializers may be relying on them),
and doing so may violate @typescript-eslint/member-ordering. Additionally, it likely requires effort to
update existing unit tests.
See: https://github.com/ni/javascript-styleguide/issues/190
*/
'@angular-eslint/prefer-inject': 'off',
'@angular-eslint/prefer-standalone': 'off',

/*
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"!/eslint.config.js"
],
"peerDependencies": {
"angular-eslint": "^19.8.1",
"angular-eslint": "^20.7.0",
"@ni/eslint-config-typescript": "^5.0.5",
"@ni/eslint-config-javascript": "^5.1.4"
}
Expand Down
14 changes: 7 additions & 7 deletions tests/angular/angular.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "./node_modules/@angular/cli/lib/config/schema.json",
"$schema": "../../node_modules/@angular/cli/lib/config/schema.json",
"version": 1,
"newProjectRoot": "projects",
"projects": {
Expand All @@ -10,7 +10,7 @@
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:application",
"builder": "@angular/build:application",
"options": {
"outputPath": "dist/angular-test",
"index": "src/index.html",
Expand All @@ -34,7 +34,7 @@
"defaultConfiguration": "production"
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"builder": "@angular/build:dev-server",
"configurations": {
"production": {
"buildTarget": "angular-test:build:production"
Expand All @@ -46,10 +46,10 @@
"defaultConfiguration": "development"
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n"
"builder": "@angular/build:extract-i18n"
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"builder": "@angular/build:karma",
"options": {
"browsers": "ChromeHeadlessNoSandbox",
"polyfills": [
Expand Down Expand Up @@ -81,7 +81,7 @@
"prefix": "angular-lib",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:ng-packagr",
"builder": "@angular/build:ng-packagr",
"options": {
"project": "projects/angular-library/ng-package.json"
},
Expand All @@ -96,7 +96,7 @@
"defaultConfiguration": "production"
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"builder": "@angular/build:karma",
"options": {
"browsers": "ChromeHeadlessNoSandbox",
"polyfills": [
Expand Down
24 changes: 12 additions & 12 deletions tests/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,30 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^19.2.17",
"@angular/common": "^19.2.17",
"@angular/compiler": "^19.2.17",
"@angular/core": "^19.2.17",
"@angular/forms": "^19.2.17",
"@angular/platform-browser": "^19.2.17",
"@angular/platform-browser-dynamic": "^19.2.17",
"@angular/animations": "^20.3.15",
"@angular/common": "^20.3.15",
"@angular/compiler": "^20.3.15",
"@angular/core": "^20.3.15",
"@angular/forms": "^20.3.15",
"@angular/platform-browser": "^20.3.15",
"@angular/platform-browser-dynamic": "^20.3.15",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"zone.js": "~0.15.1"
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.2.17",
"@angular/cli": "^19.2.17",
"@angular/compiler-cli": "^19.2.17",
"@angular/localize": "^19.2.17",
"@angular/build": "^20.3.15",
"@angular/cli": "^20.3.15",
"@angular/compiler-cli": "^20.3.15",
"@angular/localize": "^20.3.15",
"@types/jasmine": "~5.1.4",
"jasmine-core": "~5.2.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"ng-packagr": "^19.2.2",
"ng-packagr": "^20.3.2",
"typescript": "~5.8.3"
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions tests/angular/projects/angular-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.0.0",
"private": true,
"peerDependencies": {
"@angular/common": "^18.2.0",
"@angular/core": "^18.2.0"
"@angular/common": "^20.3.15",
"@angular/core": "^20.3.15"
},
"dependencies": {
"tslib": "^2.3.0"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, Input } from '@angular/core';

@Component({
selector: 'angular-lib',
selector: 'angular-lib-component',
standalone: true,
/* Angular In-line Template Smoke Test */
template: '<span i18n [(id)]="name" theme="non-localized-theme-id" title="This title should be localized." i18n-title>Hello {{name}}</span>!'
Expand Down
2 changes: 1 addition & 1 deletion tests/print-evaluated-rules/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"print-evaluated-rules:no-audit": "node index.js --no-audit"
},
"peerDependencies": {
"angular-eslint": "19.8.1",
"angular-eslint": "^20.7.0",
"@ni/angular-test": "*",
"@ni/eslint-config-angular": "*",
"@ni/eslint-config-javascript": "*",
Expand Down