fix(measure): measure line should be absolutely positioned#751
Open
wallw-dev wants to merge 1 commit intongageoint:masterfrom
Open
fix(measure): measure line should be absolutely positioned#751wallw-dev wants to merge 1 commit intongageoint:masterfrom
wallw-dev wants to merge 1 commit intongageoint:masterfrom
Conversation
swtyler
pushed a commit
to swtyler/opensphere
that referenced
this pull request
Oct 9, 2019
…phere:upscanMerge to master * commit 'b5a11fbd35933af4f203e8844b99f3c4f3ca1962': fix(CSVExport): Prevent hidden columns from being included in export test(cypress): Reduces size of server responses feat(compiler): upgrade compiler and library and fix errors fix(csv): Use custom checkbox in CSV export options. feat(datebinmethod): Add Month of Year test(cypress): Removes reserved character from fixture filenames
Contributor
|
This accurately depicts what is being measured, but the user interaction in 3D with terrain is not ideal. The mouse cursor is almost always disjoint from the line being drawn. Should 3D/terrain measurements switch to straight line distance and use the exact coordinate ( |
Contributor
Author
|
That's possible but we'll need to update the measurement as the terrain is loaded and each vertex is moved due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measure lines should be drawn on the mean ellipsoid surface since that is where the calculation is occurring. If we want the line clamped to terrain then we will need to pull the highest quality meshes that intersect the line, clamp the line, and calculate distance from that.