Skip to content

Sample IDs should work without underscores#160

Open
edmundmiller wants to merge 2 commits intodevfrom
sample_underscore
Open

Sample IDs should work without underscores#160
edmundmiller wants to merge 2 commits intodevfrom
sample_underscore

Conversation

@edmundmiller
Copy link
Collaborator

@edmundmiller edmundmiller commented Aug 17, 2024 •
edited
Loading

Closes #158

@dmitrymyl just made a test case for now, it passed so I'm not sure where the bug is.

Could you try your full run on the dev branch?

@edmundmiller edmundmiller self-assigned this Aug 17, 2024
@github-actions
Copy link

github-actions bot commented Aug 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d1c51a0

+| ✅ 199 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-17 16:14:57

@edmundmiller edmundmiller marked this pull request as ready for review August 17, 2024 16:12
@dmitrymyl
Copy link

dmitrymyl commented Aug 19, 2024

I ran the pipeline dev version with samplesheet:

sample,fastq_1,fastq_2
REP1,./sortmerna/SRR1693611/out/other.fq.gz,
REP2,./sortmerna/SRR1693612/out/other.fq.gz,

The sample names are different in this case, since I cannot run latest version with the same sample name.
It failed with:

ERROR ~ Error executing process > 'NFCORE_NASCENT:NASCENT:TRANSCRIPT_INDENTIFICATION:GROHMM:GROHMM_PARAMETERTUNING (REP2)'

Caused by:
  No such variable: bam -- Check script '/users/dmitry.mylarshchikov/.nextflow/assets/nf-core/nascent/./workflows/../subworkflows/local/./grohmm/../../../modules/local/grohmm/parametertuning/main.nf' at line: 26

Source block:
  def args = task.ext.args ?: ''
  def prefix = task.ext.prefix ?: "${meta.id}"
  """
      parameter_tuning.R \\
          --bam_file ${bam} \\
          --tuning_file ${tune_parameter_file} \\
          --outprefix ${prefix} \\
          --gtf $gtf \\
          --outdir ./ \\
          --cores $task.cpus \\
          $args

      cat <<-END_VERSIONS > versions.yml
      "${task.process}":
          r-base: \$(echo \$(R --version 2>&1) | sed 's/^.*R version //; s/ .*\$//')
          bioconductor-grohmm: \$(Rscript -e "library(groHMM); cat(as.character(packageVersion('groHMM')))")
      END_VERSIONS
      """

@edmundmiller
Copy link
Collaborator Author

edmundmiller commented Aug 22, 2024

Okay, that's out of bounds 😆

sample,fastq_1,fastq_2
replicate1,./sortmerna/SRR1693611/out/other.fq.gz,
replicate2,./sortmerna/SRR1693612/out/other.fq.gz,

Maybe?

Might be able to improve the error handling earlier in the pipeline with nf-schema to abort if is a name is just REP1

@dmitrymyl
Copy link

dmitrymyl commented Aug 30, 2024

I renamed samples to "replicate1" and "replicate2", and I still get the same error from GROHMM_PARAMETERTUNING.

@famosab
Copy link

famosab commented Mar 10, 2025

Small bump on this PR (spring cleaning)! @edmundmiller
Maybe this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@edmundmiller edmundmiller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edmundmiller @dmitrymyl @famosab

Comments