-
Notifications
You must be signed in to change notification settings - Fork 954
migrate fastp and fastplong to topics version channels #9745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate fastp and fastplong to topics version channels #9745
Conversation
|
@nf-core-bot fix linting |
|
You need to also remove the mixing of the ch_versions from the subworkflows that use fastp (and regenerate the snapshots). |
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update subworkflows
Does this mean I would have to update all other modules in all of the subworkflows that use fastp or fastplong as well to complete this PR? |
|
no, subworkflows should support the mixed usage of versions |
Updating fastp and fastplong modules to migrate versions to topic channels.
PR checklist
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda