Open
Conversation
samedii
reviewed
Dec 4, 2021
Collaborator
samedii
left a comment
samedii
left a comment
There was a problem hiding this comment.
Sorry I didn't realize that this was posted to me. From what I've read the client_id has to be in the audience or it's not valid.
It might be nicer to verify an extra audience by either looking at the token you receive or using a custom token with pydantic validation?
aud: Union[str, List[str]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately I have to deal with an auth server that is not compliant with OIDC standard. In my special case the
audienceis not equal toclient_id. I would appreciate it if audience could be specified again as an optional argument.This is related to following discussion: HarryMWinters#25 (comment)