fix: still setup for user when setting up root path with children #57910
+57
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
come-nc,
leftybournes,
nfebe and
sorbaugh
and removed request for
a team
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 29, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
setup-root-path-children
branch
2 times, most recently
from
5f63e56 to
61db338
Compare
nickvergessen
approved these changes
Jan 29, 2026
artonge
approved these changes
Jan 29, 2026
icewind1991
force-pushed
the
setup-root-path-children
branch
from
61db338 to
75fe4c9
Compare
Member
Author
|
Sharding failures unrelated: #57915 |
Member
Failing integration test sounds related and seems still not fixed? |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
setup-root-path-children
branch
from
75fe4c9 to
502567d
Compare
Member
Author
|
re-requesting reviews since 502567d is significant |
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 31, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 31, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
setup-root-path-children
branch
from
502567d to
5a9d352
Compare
icewind1991
force-pushed
the
setup-root-path-children
branch
3 times, most recently
from
cd4e5b8 to
bad72fc
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
setup-root-path-children
branch
from
bad72fc to
7982ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #57829, when setting up with children, we still setup the full user, not just the root.