Skip to content

feat: Add office switcher with feature comparison#7421

Merged
szaimen merged 6 commits intomainfrom
feat/office-switcher
Jan 28, 2026
Merged

feat: Add office switcher with feature comparison#7421
szaimen merged 6 commits intomainfrom
feat/office-switcher

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 14, 2026

Implements the office switcher from #7198

Screenshot 2026-01-14 at 22 21 40

I'm unable to test with the actual containers, only managed to get the master container itself running locally. @szaimen Can you help with that?

Patch for myself to remember how to develop locally

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @juliusknorr. I actually like the styling of the cards here better. would it be possible to apply it also to nextcloud/server#57555 ?

@szaimen szaimen added the 3. to review Waiting for reviews label Jan 15, 2026
@szaimen szaimen added this to the next milestone Jan 15, 2026
@juliusknorr juliusknorr moved this to 👀 In review in 📝 Office team Jan 15, 2026
@juliusknorr juliusknorr self-assigned this Jan 15, 2026
@szaimen szaimen modified the milestones: v12.5.0, next Jan 15, 2026
@szaimen
Copy link
Collaborator

szaimen commented Jan 20, 2026

Hey @juliusknorr , thanks a lot for the PR! ☺️

I'm unable to test with the actual containers, only managed to get the master container itself running locally. @szaimen Can you help with that?

Usually I would recommend to follow https://github.com/nextcloud/all-in-one/blob/main/develop.md#how-to-locally-build-and-test-changes-to-mastercontainer. You might be able to also combine this with #6817.

@szaimen
Copy link
Collaborator

szaimen commented Jan 20, 2026

BTW @juliusknorr can you please fix the Playwright test?

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments from a layout perspective. I think we should:

  • Reduce the vertical spacing between the list items?
  • Make all cards the same height
  • In general it would be nice to widen the main container that wraps all the AIO interface a bit. @szaimen what do you think?

@szaimen
Copy link
Collaborator

szaimen commented Jan 21, 2026

  • In general it would be nice to widen the main container that wraps all the AIO interface a bit. @szaimen what do you think?

yeah would be possible to widen it a bit. In general we limited the width for best readability

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 21, 2026
@marcoambrosini
Copy link
Member

Just tested with the --max-width variable set to 580px and it looks pretty good. We're still below 80 characters per line and I think it looks a bit better. These cards would also benefit from it.

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 22, 2026
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@szaimen szaimen force-pushed the feat/office-switcher branch 4 times, most recently from 76eb197 to 0503cfd Compare January 23, 2026 12:04
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed some details and tested this locally but this still needs some css fixes for when the elements are disabled to correctly look like they are disabled and not clickable (they should be disabled when the containers are running).

image

@juliusknorr can you please take care of this? Thanks in advance :)

Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the feat/office-switcher branch from 0503cfd to 3e62ba0 Compare January 23, 2026 12:11
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 23, 2026
@marcoambrosini
Copy link
Member

@juliusknorr in the last screenshot from @szaimen, the disable button that should be underneath the cards is not visible anymore, was it decided to remove that?

@szaimen
Copy link
Collaborator

szaimen commented Jan 26, 2026

@juliusknorr in the last screenshot from @szaimen, the disable button that should be underneath the cards is not visible anymore, was it decided to remove that?

I removed it in the case the containers are running because it does not make sense to show it while you cannot change your office selection. It gets shown again after you stop the containers

…containers are running

Signed-off-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
@emberfiend
Copy link
Contributor

Screenshot from 2026-01-27 12-03-25

just a simple 50% opacity :)

Copy link
Contributor

@emberfiend emberfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Signed-off-by: Simon L. <szaimen@e.mail.de>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :)

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 28, 2026
@szaimen szaimen merged commit 3f4eeca into main Jan 28, 2026
7 checks passed
@szaimen szaimen deleted the feat/office-switcher branch January 28, 2026 08:53
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Jan 28, 2026
@szaimen
Copy link
Collaborator

szaimen commented Jan 28, 2026

Thanks everyone ☺️

@szaimen
Copy link
Collaborator

szaimen commented Jan 30, 2026

This is now released with v12.6.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

4 participants