feat: Add office switcher with feature comparison#7421
Conversation
794eb1f to
d42f84d
Compare
marcoambrosini
left a comment
There was a problem hiding this comment.
Very nice @juliusknorr. I actually like the styling of the cards here better. would it be possible to apply it also to nextcloud/server#57555 ?
|
Hey @juliusknorr , thanks a lot for the PR!
Usually I would recommend to follow https://github.com/nextcloud/all-in-one/blob/main/develop.md#how-to-locally-build-and-test-changes-to-mastercontainer. You might be able to also combine this with #6817. |
|
BTW @juliusknorr can you please fix the Playwright test? |
marcoambrosini
left a comment
There was a problem hiding this comment.
a few more comments from a layout perspective. I think we should:
- Reduce the vertical spacing between the list items?
- Make all cards the same height
- In general it would be nice to widen the main container that wraps all the AIO interface a bit. @szaimen what do you think?
yeah would be possible to widen it a bit. In general we limited the width for best readability |
d42f84d to
90a0ae9
Compare
|
Just tested with the |
Signed-off-by: Julius Knorr <jus@bitgrid.net>
3391574 to
0a650d1
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
76eb197 to
0503cfd
Compare
There was a problem hiding this comment.
I just fixed some details and tested this locally but this still needs some css fixes for when the elements are disabled to correctly look like they are disabled and not clickable (they should be disabled when the containers are running).
@juliusknorr can you please take care of this? Thanks in advance :)
Signed-off-by: Simon L. <szaimen@e.mail.de>
0503cfd to
3e62ba0
Compare
|
@juliusknorr in the last screenshot from @szaimen, the disable button that should be underneath the cards is not visible anymore, was it decided to remove that? |
I removed it in the case the containers are running because it does not make sense to show it while you cannot change your office selection. It gets shown again after you stop the containers |
…containers are running Signed-off-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
|
Thanks everyone |
|
This is now released with v12.6.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |

Implements the office switcher from #7198
I'm unable to test with the actual containers, only managed to get the master container itself running locally. @szaimen Can you help with that?
Patch for myself to remember how to develop locally