2단계 - 수강신청(도메인 모델) #833
Open
2단계 - 수강신청(도메인 모델) #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Session 도메인을 구현했습니다 (기간, 커버이미지, 상태, 수강정책) - 무료/유료 강의 수강신청 검증 로직을 추가했습니다 - CoverImage 값 객체를 구현했습니다 (크기, 타입, 비율 검증) - Course-Session 관계를 구현했습니다 - 일급컬렉션을 적용했습니다 (Students, Sessions)
- EnrollmentPolicy에 정적 팩토리 메서드를 적용했습니다 (free(), paid()) - 무료 강의는 정원 제한 없이 수강신청할 수 있도록 수정했습니다 - 테스트 코드를 정적 팩토리 메서드 사용으로 변경했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Students,Sessions를 구현했습니다.Period,CoverImage,EnrollmentPolicy를 구현했습니다.🤔 고민한 점 및 질문
courses/domain/아래에image/,session/패키지를 분리했습니다. 적절하게 분리가 되어있는지 고민이 되었습니다.