-
Notifications
You must be signed in to change notification settings - Fork 52
jaws.bar #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
park0503
wants to merge
19
commits into
next-step:main
Choose a base branch
from
park0503:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
jaws.bar #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 정규식을 이용한 포맷 검증 메소드 - 중복 숫자 검증 메소드
- 문자열 -> 정수 List 변환 메소드 구현
- InputParser의 parsing 메소드 내 중복검사 로직 추가 - InputValidator 내의 기존 중복검사 메소드 제거
- NumberGenerator 클래스 내 랜덤 숫자 생성 메소드 구현 - Numbers model 생성
- Input 인터페이스 구현 - Output 인터페이스 구현 - Console 구현체 구현
- BallCount 모델 생성 - Numbers 모델 내 ball 수 판단 메소드 구현 - Numbers 모델 내 strike 수 판단 메소드 구현
- 기본적인 게임 flow 구현 - 반복 가능하게 설계
- ball 수 판단 로직 수정 - 일치 수 0개일 시 출력 추가 - 기타 출력 일부 수정
- 올바른 format의 input 테스트 - 올바르지 않은 format의 input 테스트
- InputParser 테스트 구현 - 입력값 중복처리 제거
- 모든 스트라이크-볼 조합 테스트
- InputParser의 parsing 메소드에 중복된 숫자 검사 로직 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.