Skip to content

Conversation

@TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Nov 4, 2025

Overview

  • Add ability to supply an instance of BaseException as an argument to notice_error and have it be unpacked into an exception tuple before processing.
  • Add tests to ensure the behavior reports the correct exception even when sys.exc_info() would return a different one.

Related Issues

Rework of #1564

@TimPansino TimPansino requested a review from a team as a code owner November 4, 2025 00:33
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.8s
✅ MARKDOWN markdownlint 7 0 0 0 1.32s
✅ PYTHON ruff 960 0 0 0 0.97s
✅ PYTHON ruff-format 960 0 0 0 0.37s
✅ YAML prettier 15 0 0 0 1.43s
✅ YAML v8r 15 0 0 5.97s
✅ YAML yamllint 15 0 0 0.7s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.66%. Comparing base (f8b4068) to head (ccf0802).

Files with missing lines Patch % Lines
newrelic/core/stats_engine.py 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
- Coverage   81.67%   81.66%   -0.01%     
==========================================
  Files         209      209              
  Lines       24392    24396       +4     
  Branches     3870     3872       +2     
==========================================
+ Hits        19923    19924       +1     
- Misses       3159     3161       +2     
- Partials     1310     1311       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the tests-failing Tests failing in CI. label Nov 14, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Nov 17, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Dec 2, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Dec 12, 2025
@TimPansino TimPansino force-pushed the fix-notice-error-logic branch from 6e2dd61 to ccf0802 Compare December 17, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants