Bipartite rewiring network with Guilherme #30
Open
aleurbi wants to merge 6 commits intonetsiphd:mainfrom
Open
Conversation
nwlandry
requested changes
Jul 20, 2022
Collaborator
nwlandry
left a comment
nwlandry
left a comment
There was a problem hiding this comment.
Overall looks good, just a few changes :)
netrw/rewire/RewireBipartite.py
Outdated
|
|
||
| return G | ||
|
|
||
| def full_rewire(self, G, accuracy, max_step=0, copy_graph=True, verbose=False): |
Collaborator
There was a problem hiding this comment.
max_step should be called timesteps to be consistent with other methods.
netrw/rewire/RewireBipartite.py
Outdated
|
|
||
| # Single step: Stochastic | ||
| # This method may return the same graph | ||
| def step_rewire(self, G): |
Collaborator
There was a problem hiding this comment.
I think we agreed on a copy_graph keyword with a False default value for step_rewire as well?
| import random as rand | ||
|
|
||
|
|
||
| class RewireBipartite(BaseRewirer): |
Collaborator
There was a problem hiding this comment.
Could you add a check to see whether the input graph is, in fact, bipartite?
Collaborator
There was a problem hiding this comment.
In the step_rewire method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(need to be optimized a bit, we are working on it)