fix: resolve static asset loading with trailing slash #3618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers treat URLs with trailing slash as directories - URLs with trailing slash use './' baseUrl This ensures assets load correctly regardless of how users access the Swagger UI endpoint. Fixes nestjs#3617
lukekluky
reviewed
Nov 10, 2025
| res.type('text/html'); | ||
|
|
||
| const url = httpAdapter.getRequestUrl(req); | ||
| const hasTrailingSlash = url.endsWith('/'); |
There was a problem hiding this comment.
Does this issue also occur when you set the path without a trailing slash. For example, SwaggerModule.setup('api', ...) ?
There was a problem hiding this comment.
Yes is does I'm experiencing the same issue with the following
https://api.beta.playtak.com/api/
https://github.com/USTakAssociation/playtak-api/blob/dev/api/src/main.ts
Member
|
Could you add corresponding tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3617
When users access Swagger UI with a trailing slash (e.g.,
/api-docs/), the browser requests static assets using incorrect paths like/api-docs/api-docs/swagger-ui.css, resulting in 404 errors.What is the new behavior?
Browsers treat URLs differently based on trailing slash:
/api-docs→ treated as a file, relative paths resolve from parent directory//api-docs/→ treated as a directory, relative paths resolve from/api-docs/The Swagger UI now serves correct HTML with appropriate
baseUrlbased on this behavior:/api-docs→ uses./api-docs/baseUrl (resolves to/api-docs/swagger-ui.css)/api-docs/→ uses./baseUrl (resolves to/api-docs/swagger-ui.css)Both URL patterns now correctly load static assets regardless of trailing slash presence.
Does this PR introduce a breaking change?
Other information