Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a parallel compression path for LZ4/LZ4Fast in bundle packing. To preserve compatibility with
net35targets, this parallel path is only enabled on non-net35builds, whilenet35continues using the original sequential implementation.The mechanism is straightforward: it takes a batch of consecutive blocks and compresses them concurrently with
Parallel.For. The batch size is configurable throughLz4ParallelPackBatchSize, with a default value of32. This default was selected based on benchmarking on my local laptop (Intel(R) Core(TM) i7-13650HX, 32G DDR5 mem, Linux 6.6.87.2-microsoft-standard-WSL2). In the benchmarking, I used a byte-counting stream to eliminate the impact of disk I/O.Benchmarking logs are
I know this implementation still does not fully saturate all available performance potential, but in my observation it already keeps CPU utilization stably above 80%, which is sufficient for most cases.